feat(besoins): méthode pour dupliquer un besoin #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/tender-duplicate-helper
branch
from
4470298
to
613f5c1
Compare
raphodn
force-pushed
the
raphodn/tender-duplicate-helper
branch
from
613f5c1
to
02351cc
Compare
madjid-asa
reviewed
Feb 21, 2024
lemarche/www/tenders/utils.py
Outdated
Comment on lines
103
to
108
| def duplicate(tender: Tender) -> Tender: | ||
| FIELDS_TO_REMOVE = ( | ||
| ["_state", "_django_version"] | ||
| + ["id", "slug", "siae_transactioned", "extra_data", "import_raw_object"] | ||
| + Tender.READONLY_FIELDS | ||
| ) |
There was a problem hiding this comment.
Suggested change
| def duplicate(tender: Tender) -> Tender: | |
| FIELDS_TO_REMOVE = ( | |
| ["_state", "_django_version"] | |
| + ["id", "slug", "siae_transactioned", "extra_data", "import_raw_object"] | |
| + Tender.READONLY_FIELDS | |
| ) | |
| FIELDS_TO_REMOVE = ( | |
| ["_state", "_django_version"] | |
| + ["id", "slug", "siae_transactioned", "extra_data", "import_raw_object"] | |
| + Tender.READONLY_FIELDS | |
| ) | |
| def duplicate(tender: Tender, fields_to_remove=FIELDS_TO_REMOVE) -> Tender: |
Je le mettrais en argument au cas où ^^
L'autre option serait de laisser comme t'as fait initialement et t'ajoute un argument à duplicate du type extra_fields_to_remove
There was a problem hiding this comment.
okay t'as raison je vais rendre ca un peu plus réutilisable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Nouveau utils
duplicate(tender)Ajout de test
Pourquoi ?
Parfois demandé par un admin. En attendant de rajouter un bouton