Removed move_to_XXX kernels and COO::transpose
#288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoasm
added
reg:testing
thoasm
force-pushed
the
matrix_replace_move_to
branch
3 times, most recently
from
463eacd to
c027ab3
Compare
tcojean
approved these changes
Apr 4, 2019
hartwiganzt
approved these changes
Apr 4, 2019
Removed unused `move_to_XXX` kernels from Dense and Csr. All calls to `move_to(Mtx *)`, which previously used the mentioned kernels, now use `convert_to_XXX` kernels. Since we did not implement any transpose functionality in Coo, the inheritance from `Transposable` and all related kernels were removed. Additionally, the tests for Coo, Csr & Dense were modified as follows: - Made include order compliant to guidelines - Newlines in the tests are also according to guidelines - Added MoveTo tests where they were not present - Added tests for Dense conversions (used already generated variables) The conversion from Dense to Hybrid with OpenMP was also slightly improved.
thoasm
force-pushed
the
matrix_replace_move_to
branch
from
c027ab3 to
5545d20
Compare
thoasm
added
1:ST:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused
move_to_XXXkernels from Dense and Csr. All calls tomove_to(Mtx *), which previously used the mentioned kernels, now useconvert_to_XXXkernels.Since we did not implement any transpose functionality in Coo, the inheritance from
Transposableand all related kernels were removed.Additionally, the tests for Coo, Csr and Dense were modified as follows:
MoveTotests where they were not presentThe conversion from Dense to Hybrid with OpenMP was also slightly improved.
Takes care of a part of #286.