Merge pull request #10 from gimnathperera/ci/github-package-configura…

…tions Ci/GitHub package configurations
gimnathperera · Sep 18, 2023 · 0250442 · 0250442
2 parents 3ed3a20 + 6f684e5
commit 0250442
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/.changeset/eight-chicken-search.md b/.changeset/eight-chicken-search.md
@@ -0,0 +1,5 @@
+---
+'@gimnathperera/react-mui-multi-search': patch
+---
+
+fix: applying same filter value for the same key
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -26,8 +26,6 @@ jobs:
 
       - name: Install dependencies
         run: npm install --frozen-lockfile
-      - name: Debug NPM_AUTH_TOKEN
-        run: echo $NPM_AUTH_TOKEN
 
       - name: Create Release Pull Request or Publish
         id: changesets
@@ -37,10 +35,3 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
-
-      - name: Publish to GitHub Packages
-        run: |
-          echo "//npm.pkg.github.com/:_authToken=\${NODE_AUTH_TOKEN}" >> ~/.npmrc
-          npm publish --registry=https://npm.pkg.github.com
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/src/components/MultiSearch/MultiSearch.tsx b/src/components/MultiSearch/MultiSearch.tsx
@@ -31,6 +31,11 @@ export const MultiSearch: React.FC<Props> = ({
   }, [onPrint]);
 
   const handleAddFilterByParam = useCallback(({ filterKey, filterValue }: FilteredBy) => {
+    const filterExists = searchParams.find(
+      param => param.key === filterKey && param.value === filterValue,
+    );
+    if (filterExists) return;
+
     setSearchParams(prevSearchParams => [
       ...prevSearchParams,
       { key: filterKey, value: filterValue },
@@ -74,11 +79,11 @@ export const MultiSearch: React.FC<Props> = ({
           </StyledIconButton>
         </SearchBarContainer>
       </Grid>
-      {searchParams.length > 0 && (
+      {searchParams.length > 0 ? (
         <Grid item xs={12}>
           <AppliedFilters searchParams={searchParams} onDelete={handleRemoveSearchParam} />
         </Grid>
-      )}
+      ) : null}
     </Grid>
   );
 };