Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add support to custom t names on custom translation hooks #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guiedugt
Copy link

Using custom t names combined with custom translation hooks is not working as expected.
For example, the translation keys will not be extracted:

function MyComponent() {
  const { myTranslationFunction } = useMyTranslationHook('namespace');

  return <p>{myTranslationFunction('myTranslationKey')}</p>;
}

After some investigation, I found this is due to a hardcoded "t" key inside the useTranslationHook extractor:

const tBinding = id.scope.bindings['t'];

This PR adds some simple logic to try out different function names in the order they are defined in the tFunctionNames configuration parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant