Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

Updates for 1.7 cadvisor changes and rbac requirements #73

Merged
merged 7 commits into from
Nov 7, 2018

Conversation

zatricky
Copy link
Contributor

Notes:

  • I'm not enabling rbac - but have at least made appropriate changes to the commented rbac rules. This works with rbac enabled with kubeadm-generated clusters.
  • I've included joshes' /var/lib/grafana fix, though I see he also has a separate pull request for that

See also:

joshes and others added 6 commits August 30, 2017 16:28
Using /var would remove grafana-specific data whereas using /var/lib/grafana as per the official Dockerfile reference states, it works as expected after pod deletion(s).
Fix issue with grafana-specific data not persisting
@MarcelMue MarcelMue self-requested a review August 31, 2017 15:35
@MarcelMue MarcelMue self-assigned this Aug 31, 2017
@MarcelMue
Copy link
Contributor

This is breaking for K8s 1.7.2 and below, correct? If so, then please add a note about this being the case in the readme.

I will do some testing from my side shortly.

@zatricky
Copy link
Contributor Author

zatricky commented Sep 1, 2017

I'll see if I can roll out some older 1.7.x clusters to test.

@dominikhahn
Copy link

Tested on 1.7.6 cluster. Works fine. Thanks @zatricky !

@zburgermeiszter
Copy link

zburgermeiszter commented Dec 15, 2017

Closes:
#79 #89 #88 #86 #84

sctsang referenced this pull request in sctsang/kubernetes-prometheus Feb 15, 2018
timn referenced this pull request in timn/rcll-sim-cluster Jun 14, 2018
Pull latest upstream and PR #73 for compatibility with K8s 1.9
(giantswarm/kube-prometheus-stack-app#73).

Then go on and upgrade to Prometheus 2.1, related tools, Grafana to
4.6.3. Make the necessary configuration changes especially to alerts for
Prometheus 2. Move import job init container into spec.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants