-
Notifications
You must be signed in to change notification settings - Fork 422
Small changes for install chart on kebernetes 1.11 #113
base: master
Are you sure you want to change the base?
Conversation
@@ -449,7 +449,7 @@ initChownData: | |||
## If false, data ownership will not be reset at startup | |||
## This allows the prometheus-server to be run with an arbitrary user | |||
## | |||
enabled: true | |||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't all of these be true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I would like to default everything to enable, you can always customize your values and use them in the installation command.
helm install -f myvalues.yaml
@@ -1,4 +1,4 @@ | |||
piVersion: v1 | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
@@ -12,4 +12,4 @@ sources: | |||
- https://github.com/prometheus/alertmanager | |||
- https://github.com/prometheus/prometheus | |||
tillerVersion: ">=2.8.0" | |||
version: 0.1.0-[[ .SHA ]] | |||
version: 0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements. A couple of comments, please take a look
@@ -1,4 +1,4 @@ | |||
piVersion: v1 | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
@@ -449,7 +449,7 @@ initChownData: | |||
## If false, data ownership will not be reset at startup | |||
## This allows the prometheus-server to be run with an arbitrary user | |||
## | |||
enabled: true | |||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I would like to default everything to enable, you can always customize your values and use them in the installation command.
helm install -f myvalues.yaml
Yea... It's was mistake... Co-Authored-By: ozlevka-ericom <[email protected]>
I make some small changes in chart and success to install on k8s 1.11.
If these changes important you welcome to merge my work to your master