Remove normal response in line with new guidelines

giantswarm · Nov 16, 2023 · 3cc9aea · 3cc9aea
1 parent 8c22846
commit 3cc9aea
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 20 deletions.
diff --git a/fn.go b/fn.go
@@ -35,7 +35,6 @@ func (f *Function) RunFunction(_ context.Context, req *fnv1beta1.RunFunctionRequ
 	}
 
 	if _, ok := ac.composed.ObservedComposed[input.Spec.ClusterRef]; !ok {
-		response.Normal(rsp, "waiting for resource")
 		return rsp, nil
 	}
 
@@ -75,6 +74,5 @@ func (f *Function) RunFunction(_ context.Context, req *fnv1beta1.RunFunctionRequ
 		return
 	}
 
-	response.Normal(rsp, "Successful run")
 	return rsp, nil
 }
diff --git a/fn_test.go b/fn_test.go
@@ -504,12 +504,6 @@ func TestRunFunction(t *testing.T) {
 			want: want{
 				rsp: &fnv1beta1.RunFunctionResponse{
 					Meta: &fnv1beta1.ResponseMeta{Tag: "hello", Ttl: durationpb.New(response.DefaultTTL)},
-					Results: []*fnv1beta1.Result{
-						{
-							Severity: fnv1beta1.Severity_SEVERITY_NORMAL,
-							Message:  "waiting for resource",
-						},
-					},
 				},
 			},
 			mocks: mocks{},
@@ -613,12 +607,6 @@ func TestRunFunction(t *testing.T) {
 			want: want{
 				rsp: &fnv1beta1.RunFunctionResponse{
 					Meta: &fnv1beta1.ResponseMeta{Ttl: durationpb.New(response.DefaultTTL)},
-					Results: []*fnv1beta1.Result{
-						{
-							Severity: fnv1beta1.Severity_SEVERITY_NORMAL,
-							Message:  "Successful run",
-						},
-					},
 					Desired: &fnv1beta1.State{
 						Composite: &fnv1beta1.Resource{
 							Resource: resource.MustStructJSON(xrExample),
@@ -687,12 +675,6 @@ func TestRunFunction(t *testing.T) {
 			want: want{
 				rsp: &fnv1beta1.RunFunctionResponse{
 					Meta: &fnv1beta1.ResponseMeta{Ttl: durationpb.New(response.DefaultTTL)},
-					Results: []*fnv1beta1.Result{
-						{
-							Severity: fnv1beta1.Severity_SEVERITY_NORMAL,
-							Message:  "Successful run",
-						},
-					},
 					Desired: &fnv1beta1.State{
 						Composite: &fnv1beta1.Resource{
 							Resource: resource.MustStructJSON(xrTest),