Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Composite Editor should reapply original date when exist & form is reset #1739

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ghiscoding
Copy link
Owner

  • when the input date wasn't ISO date format, the form reset wasn't reapplying the original date and was lost

brave_zC5Jtqwain

Copy link

stackblitz bot commented Nov 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (a786038) to head (e47292e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1739     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         187     187             
  Lines       30747   30748      +1     
  Branches     9778    9780      +2     
========================================
+ Hits        30658   30659      +1     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding changed the title fix: Composite Editor should reapply original when exist & form is reset fix: Composite Editor should reapply original date when exist & form is reset Nov 10, 2024
@ghiscoding ghiscoding merged commit f709b56 into master Nov 12, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/composite-reset-dates branch November 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant