Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DOMPurify now has built-in types & no longer require CJS bypass #1497

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 21, 2024

  • newest version of DOMPurify 3.2.x added built-in Types, so we can now remove @types/dompurify dev dependencies, the bonus is that it also fixes the allowedCommonJsDependencies bypass which is no longer required since the new build returns both CJS/ESM

Copy link

stackblitz bot commented Nov 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (658ddd6) to head (1ccb96f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1497   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          950       950           
  Branches       312       321    +9     
=========================================
  Hits           950       950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ghiscoding ghiscoding merged commit ae3d731 into master Nov 21, 2024
4 checks passed
@ghiscoding ghiscoding deleted the chore/dompurify-types branch November 21, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant