Opt class for positional argument handling #10508
Open
+92
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
force-pushed
the
new-style-run
branch
8 times, most recently
from
1454a52
to
39fa786
Compare
ericcurtin
commented
Nov 26, 2024
| @@ -134,6 +140,7 @@ class LlamaData { | |||
| private: | |||
| // Initializes the model and returns a unique pointer to it | |||
| llama_model_ptr initialize_model(const std::string & model_path, const int ngl) { | |||
| ggml_backend_load_all(); | |||
There was a problem hiding this comment.
Caught this here @slaren
ericcurtin
force-pushed
the
new-style-run
branch
from
39fa786
to
fa3ff4f
Compare
Added support for positional arguments `MODEL` and `PROMPT`. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
new-style-run
branch
from
fa3ff4f
to
be9cf7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for positional arguments
MODELandPROMPT.