Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move values into configuration settings, stop checking # of slots, use the same magic event ids #162

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Jan 21, 2024

  1. Move values into configuration, stop checking # of slots

    Try and bring ACNW and ACUS together through:
     1. Configuration values
     2.
    
    Added configuration settings:
    
    Copyright holder in footer
     - config.copyright (string)
    
    Used to set range on min and max player in creating games
     - config.playerMin (positive integer)
     - config.playerMax (positive integer)
     - config.minPlayersFloor (positive integer)
     - config.minPlayersCeiling (positive integer)
     - config.maxPlayersFloor (positive integer)
     - config.maxPlayersCeiling (positive integer)
    
    Used by ACUS on its hotel page to allow people to book in its
    block of rooms:
     - config.hotelBookingCode (string)
     - config.hotelBookingUrl (string)
     - config.hotelBookingLastdate (date)
    
    Resolves: #155, #158, #160, #161
    See also: #159
    evoskamp committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    90c6a4b View commit details
    Browse the repository at this point in the history
  2. Remove unneeded variables: use configuration

    Instead of sticking configuration.abbr in local variables of acnw and
    acus, which are essentially inverted Boolean flags, check against its
    values of 'acus' or 'acnw' directly. It's simpler, clearer, and allows
    for adding a third (even if only synthetic) site.
    
    Resolves: #155, #158, #160, #161
    See also: #159
    evoskamp committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    97acdf9 View commit details
    Browse the repository at this point in the history
  3. Move static MDX content to TSX with config settings

    Wanted to pick up hotel booking code and link and book by date, as
    we change those apparently every year. And also wanted to pick up
    the contact email from settings.
    
    Resolves: #163, #155, #158, #160, #161, #159
    evoskamp committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    98e0787 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Remove old ACNW config.ts so it doesn't clash

    Part of the changes. Guy's PR review noted to remove this.
    
    Don't know how it survived in here with all the other changes to
    config in the past, but it's a good thing to make it gone.
    evoskamp committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5fc5608 View commit details
    Browse the repository at this point in the history