-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move values into configuration settings, stop checking # of slots, use the same magic event ids #162
base: main
Are you sure you want to change the base?
Conversation
Try and bring ACNW and ACUS together through: 1. Configuration values 2. Added configuration settings: Copyright holder in footer - config.copyright (string) Used to set range on min and max player in creating games - config.playerMin (positive integer) - config.playerMax (positive integer) - config.minPlayersFloor (positive integer) - config.minPlayersCeiling (positive integer) - config.maxPlayersFloor (positive integer) - config.maxPlayersCeiling (positive integer) Used by ACUS on its hotel page to allow people to book in its block of rooms: - config.hotelBookingCode (string) - config.hotelBookingUrl (string) - config.hotelBookingLastdate (date) Resolves: #155, #158, #160, #161 See also: #159
Instead of sticking configuration.abbr in local variables of acnw and acus, which are essentially inverted Boolean flags, check against its values of 'acus' or 'acnw' directly. It's simpler, clearer, and allows for adding a third (even if only synthetic) site. Resolves: #155, #158, #160, #161 See also: #159
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Part of the changes. Guy's PR review noted to remove this. Don't know how it survived in here with all the other changes to config in the past, but it's a good thing to make it gone.
Now ACUS is over I'm going to make a copy of the database and then update the IDs for the magic events to match ACNW's. |
Changing IDs works fine. ACNW has a game in game.id = 8, but that's not a big deal as we can use 1-numberOfSlots and 144 (for Any Game). Since it doesn't matter, if we wanted to make it clean(er), we could move "Any Game" to 0 for ACNW and ACUS. |
Move values into configuration settings, stop checking # of slots, use the same magic event ids
Resolves: #155, #158, #160, #161, #159
Try and bring ACNW and ACUS closer together and clean up common code through:
Instead of sticking configuration.abbr in local variables of acnw and
acus, which are essentially inverted Boolean flags, check against its
values of 'acus' or 'acnw' directly. It's simpler, clearer, and allows
for adding a third (even if only synthetic) site.
Note, you must add these configuration settings for the deploy to succeed:
Copyright holder in footer
Used to set range on min and max player in creating games
Used by ACUS only (soon) on its hotel page to allow people to book in its
block of rooms:
To fix the SQL in the ACUS database to ACNW event ids, I run the following
SQL to commit these atrocities: