-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satisfy Rust 1.77 lints #6104
Closed
ErichDonGubler
wants to merge
11
commits into
gfx-rs:trunk
from
erichdongubler-mozilla:rust-lints-with-1.77
Closed
Satisfy Rust 1.77 lints #6104
ErichDonGubler
wants to merge
11
commits into
gfx-rs:trunk
from
erichdongubler-mozilla:rust-lints-with-1.77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
area: infrastructure
Testing, building, coordinating issues
kind: refactor
Making existing function faster or nicer
labels
Aug 12, 2024
ErichDonGubler
force-pushed
the
rust-lints-with-1.77
branch
6 times, most recently
from
August 12, 2024 12:35
bd64590
to
7ebaea9
Compare
ErichDonGubler
changed the title
Satisfy Rust lints _newer_ than 1.77 after upgrading to 1.77
Satisfy Rust 1.77 lints
Aug 12, 2024
The rationale is that this is roughly the last `nightly` 1.77 build to come out.
This resolves an upstream issue with [`--check-cfg` in Rust 1.80](https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values).
This resolves remaining outstanding cases that offend [`--check-cfg` in Rust 1.80](https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values).
ErichDonGubler
force-pushed
the
rust-lints-with-1.77
branch
from
August 12, 2024 20:43
7ebaea9
to
9b10575
Compare
This isn't necessary; the changes I thought needed to go in here were actually the result of using the 1.80 toolchain. 😅 Gonna punt stuff I had in here to #6105. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: infrastructure
Testing, building, coordinating issues
kind: refactor
Making existing function faster or nicer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6103.