Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: replace AMQP 0-9-1 reference links #159

Merged

Conversation

michaelklishin
Copy link
Contributor

They have been moved to a GitHub repository [1].

Closes #153.

  1. https://www.rabbitmq.com/amqp-0-9-1-reference.html

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (d350041) to head (6df0390).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   85.86%   85.89%   +0.02%     
==========================================
  Files          40       40              
  Lines        6658     6657       -1     
==========================================
+ Hits         5717     5718       +1     
+ Misses        941      939       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelklishin
Copy link
Contributor Author

michaelklishin commented Mar 14, 2025

The lint failure seemingly has nothing to do with this change but rather a change in the clippy version used? or the module was previously cached and re-compiled:

error: operator precedence can trip the unwary
   --> amqprs/src/frame/content_header.rs:545:21
    |
    |                 if (flags[0] & 1 << 7) != 0 {
    |                     ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `flags[0] & (1 << 7)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
    = note: `-D clippy::precedence` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::precedence)]`

I'd be happy to address the warning if @gftea wants me to.

@gftea
Copy link
Owner

gftea commented Mar 15, 2025

@michaelklishin thanks! Yes, must due to new clippy version, much appreciate if you could help fixing them

@michaelklishin
Copy link
Contributor Author

@gftea done!

@gftea
Copy link
Owner

gftea commented Mar 16, 2025

Thanks! @michaelklishin

@gftea gftea merged commit 9c46ddc into gftea:main Mar 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMQP reference documentation was moved to github
2 participants