Implement zola serve --store-html #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
Dec 28, 2024
components/site/src/lib.rs
Outdated
| @@ -114,10 +116,10 @@ impl Site { | |||
| } | |||
|
|
|||
| /// Enable some `zola serve` related options | |||
| pub fn enable_serve_mode(&mut self) { | |||
| pub fn enable_serve_mode(&mut self, both: bool) { | |||
There was a problem hiding this comment.
there's an enum for it, use it in the params instead of a bool
There was a problem hiding this comment.
Does the new commit correspond to your idea?
I can also squash it onto the previous commit.
|
Looks like legit tests failures |
|
Yes indeed! |
|
Yes that's fine, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2377