Improve multi-language support (take 2) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxter184
commented
Jul 4, 2022
jaxter184
force-pushed
the
master
branch
3 times, most recently
from
465faf7 to
80c1a36
Compare
|
Is there anything else I need to do to get this merged? |
Keats
reviewed
Jul 16, 2022
jaxter184
force-pushed
the
master
branch
2 times, most recently
from
83b37ea to
9090f12
Compare
|
|
|
Don't worry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to clutter the pull requests; seems like I accidentally pushed the wrong commit to my fork, and I'm not sure how to reopen the old PR.
I squashed the
config.languages | lengthchange into the first commit, and added a second (tentative) commit changing the default example to show the multi-language capabilities. I'm a little uncertain whether the extra config options are the best move though. I feel like multi-language support is a bit of a rare case, and 99% of people will just want a one language thing. It adds a lot of extra information, so maybe it would be better to put this information in the README? or in a second file as a separate guide?