chore: Add gpt-4o-2024-08-06 support #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-paliychuk
temporarily deployed
to
build-test
GitHub Actions
Inactive
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to dd5afe2 in 13 seconds
More details
- Looked at
27lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/llms/llm_base.go:163
- Draft comment:
The addition ofgpt-4o-2024-08-06to theValidOpenAILLMsmap is correctly implemented, ensuring the new model is recognized as valid by the system. This change aligns with the updated model list inconfig.yaml. - Reason this comment was not posted:
Confidence changes required:0%
The PR adds support for a new OpenAI model,gpt-4o-2024-08-06, in the configuration and validation maps. The changes inconfig.yamlandllm_base.goare consistent with each other, ensuring that the new model is recognized as valid. The PR description is empty, but the title indicates the intent clearly. The changes are minimal and focused, affecting only the necessary parts of the configuration and validation logic. There are no apparent logical, performance, or security issues with the changes made. The PR seems to be straightforward and correctly implemented based on the intent to support a new model version.
Workflow ID: wflow_PBHFLndfqzqZMxAJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Also maybe in a near future once it has been tested enough, this model could replace the default llm model used in config and in openai tests since it's faster and cheaper (and globally better) than 3.5 turbo. I didn't put it here but I can make a separate PR for this if you want |
|
@bricemacias Yes that is a good idea to default to 4o-mini, a PR would be welcome! |
|
@paul-paliychuk done here #354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added support for
gpt-4o-2024-08-06model inconfig.yamlandpkg/llms/llm_base.go.Key points:
gpt-4o-2024-08-06toconfig.yamlunder OpenAI models.pkg/llms/llm_base.goto includegpt-4o-2024-08-06inValidOpenAILLMsmap.gpt-4o-2024-08-06is recognized as a valid model in OpenAI LLM validation logic.Generated with ❤️ by ellipsis.dev