Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the README's demo gif. #1711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denschub
Copy link

This is, of course, a very critical bug and I'm very disappointed in this project - this unacceptable issue should have been fixed years ago.

I am kidding. But it still tickled me. This PR also removes the dependency on imgur, and replaces the 2 MiB GIF with a 1.3 MiB GIF.

Fixes #1126

Signed-off-by: Dennis Schubert <[email protected]>
@denschub denschub force-pushed the very-important-docs-fix branch from 7b408aa to d0c4814 Compare December 18, 2024 23:01
@felixfontein
Copy link
Contributor

I don't really like the idea of adding a 1.3 MiB blob to the repository, but right now I'm not sure of a better solution. Maybe we should add another repository for such binary data, and put the GIF there? @getsops/maintainers what do you think?

@denschub
Copy link
Author

@felixfontein I mean, if you want, you can also upload it to imgur again, send me the URL, and I'll update the PR. I just didn't do it, because it feels .. very wrong for this to be done by someone not even affiliated with the project. :)

@felixfontein
Copy link
Contributor

imgur is definitely a worse place where the image could live than a repository in https://github.com/getsops/. But I don't think it should be https://github.com/getsops/sops/ either. Putting binary blobs into code repositories is generally not a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in readme file
3 participants