-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSH support for age #1692
base: main
Are you sure you want to change the base?
Add SSH support for age #1692
Conversation
This PR rebases #1134 and includes |
if err != nil { | ||
return nil, err | ||
} | ||
defer in.Close() |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling Warning
call to OpenFile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getsops/maintainers I'm pretty sure these warnings (there are two more further down in this file) can be dismissed since we don't need to ensure that data is written in case of errors. Does that sound correct to you?
if err != nil { | ||
return nil, err | ||
} | ||
defer out.Close() |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling Warning
call to OpenFile
if err != nil { | ||
return nil, err | ||
} | ||
defer tty.Close() |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling Warning
call to OpenFile
220e7dc
to
b325a74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, and sorry it took so long to review it...
Signed-off-by: Marvin Strangfeld <[email protected]>
Signed-off-by: haoqixu <[email protected]>
Signed-off-by: haoqixu <[email protected]>
Signed-off-by: haoqixu <[email protected]>
Signed-off-by: haoqixu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, up to two details in go.mod and the open discussions on the Code scanning warnings.
Signed-off-by: haoqixu <[email protected]>
Continues #1134.
Closes #1134
Closes #1496
Fixes #692