Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync notes checkbox to PR template #4304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add sync notes checkbox to PR template #4304

wants to merge 1 commit into from
+1 −0

Conversation

sheepman4267
Copy link
Member

Summary

This adds an item to the checklist prompting maintainers to let us know if they think the change should be mentioned in the sync notes. As suggested by @ReillyBrogan in matrix.

Test Plan

N/A, this is a change to github configuration.

Checklist

  • Package was built and tested against unstable

ermo
ermo reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider replacing "should" with "could gainfully" to indicate that the contributor is suggesting that there are gotchas or notable changes that warrant highlighting for the sake of users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermo ermo ermo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Solus
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheepman4267 @ermo