Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Start using profile information in span tree #692

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

BYK
Copy link
Member

@BYK BYK commented Feb 4, 2025

First phase of #565.

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 0:16am

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 34.56790% with 212 lines in your changes missing coverage. Please review.

Project coverage is 30.91%. Comparing base (1ffe90f) to head (34570ba).

Files with missing lines Patch % Lines
...s/overlay/src/integrations/sentry/data/profiles.ts 21.90% 164 Missing ⚠️
...ay/src/integrations/sentry/data/sentryDataCache.ts 52.80% 42 Missing ⚠️
...ntegrations/sentry/components/events/EventList.tsx 0.00% 1 Missing ⚠️
...e/traces/TraceDetails/components/TraceTreeview.tsx 0.00% 1 Missing ⚠️
...y/components/explore/traces/TraceDetails/index.tsx 0.00% 1 Missing ⚠️
...entry/components/explore/traces/spans/SpanItem.tsx 0.00% 1 Missing ⚠️
packages/overlay/src/integrations/sentry/index.ts 0.00% 1 Missing ⚠️
...es/overlay/src/integrations/sentry/utils/traces.ts 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   31.86%   30.91%   -0.96%     
==========================================
  Files          92       93       +1     
  Lines        5507     5791     +284     
  Branches      102       84      -18     
==========================================
+ Hits         1755     1790      +35     
- Misses       3752     4001     +249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant