trying

getsentry · Feb 5, 2025 · 0383292 · 0383292
1 parent 1f4f3a7
commit 0383292
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/snuba/web/rpc/v1/resolvers/R_eap_spans/resolver_get_trace.py b/snuba/web/rpc/v1/resolvers/R_eap_spans/resolver_get_trace.py
@@ -1,4 +1,5 @@
 import uuid
+from datetime import datetime
 from operator import attrgetter
 from typing import Any, Dict, Iterable
 
@@ -88,7 +89,9 @@ def _build_query(request: GetTraceRequest) -> Query:
         ]
         selected_columns.extend(
             [
-                SelectedExpression(name=col_name, expression=column(col_name))
+                SelectedExpression(
+                    name=col_name, expression=column(col_name, alias=col_name)
+                )
                 for col_name in [
                     "organization_id",
                     "project_id",
@@ -192,14 +195,14 @@ def _value_to_attribute(key: str, value: Any) -> tuple[AttributeKey, AttributeVa
                 val_double=value,
             ),
         )
-    elif isinstance(value, str):
+    elif isinstance(value, str) or isinstance(value, datetime):
         return (
             AttributeKey(
                 name=key,
                 type=AttributeKey.Type.TYPE_STRING,
             ),
             AttributeValue(
-                val_str=value,
+                val_str=str(value),
             ),
         )
     else:

diff --git a/tests/web/rpc/v1/test_endpoint_get_trace.py b/tests/web/rpc/v1/test_endpoint_get_trace.py
@@ -266,7 +266,9 @@ def test_with_data(self, setup_teardown: Any) -> None:
                 ),
             ],
         )
-        assert MessageToDict(response) == MessageToDict(expected_response)
+        assert MessageToDict(response.item_groups[0]) == MessageToDict(
+            expected_response.item_groups[0]
+        )
 
     def test_with_specific_attributes(self, setup_teardown: Any) -> None:
         ts = Timestamp(seconds=int(_BASE_TIME.timestamp()))