🔧 chore: remove redundant slack logging & metrics #82852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## raj/clean-slack-slo-logging-1 #82852 +/- ##
=================================================================
- Coverage 87.50% 87.50% -0.01%
=================================================================
Files 9410 9410
Lines 536814 536793 -21
Branches 21049 21049
=================================================================
- Hits 469724 469699 -25
- Misses 66721 66725 +4
Partials 369 369 |
GabeVillalobos
approved these changes
Jan 3, 2025
Comment on lines
-101
to
-108
| logger.error(".unlink-user.no-identity.error", extra={"slack_request": slack_request}) | ||
| metrics.incr(self._METRIC_FAILURE_KEY + "unlink_user.no_identity", sample_rate=1.0) | ||
|
|
||
| return self.reply(slack_request, NOT_LINKED_MESSAGE) | ||
|
|
||
| if not (slack_request.integration and slack_request.user_id and slack_request.channel_id): | ||
| logger.error(".unlink-user.bad_request.error", extra={"slack_request": slack_request}) | ||
| metrics.incr(self._METRIC_FAILURE_KEY + "unlink_user.bad_request", sample_rate=1.0) |
There was a problem hiding this comment.
Let's update our webhook metrics dashboards for webhooks before merging this please!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing #82744
we have completed the audit of our integration slos, so going back and cleaning up redundant logging and metrics.
we should also monitor our DD monitors to see if they need updating.