ref(issue-list): Create copy of overview.tsx as a functional component #82784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/ref/issue-list-overview-fc
branch
from
15c5805 to
659b4d7
Compare
malwilley
force-pushed
the
malwilley/ref/issue-list-overview-fc
branch
from
13822c7 to
34f14ad
Compare
Bundle ReportChanges will increase total bundle size by 18.7kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
scttcper
reviewed
Jan 2, 2025
scttcper
reviewed
Jan 2, 2025
scttcper
approved these changes
Jan 3, 2025
scttcper
reviewed
Jan 3, 2025
scttcper
reviewed
Jan 3, 2025
MichaelSun48
reviewed
Jan 3, 2025
| import withOrganization from 'sentry/utils/withOrganization'; | ||
| import withPageFilters from 'sentry/utils/withPageFilters'; | ||
| import withSavedSearches from 'sentry/utils/withSavedSearches'; | ||
| import CustomViewsIssueListHeader from 'sentry/views/issueList/customViewsHeader'; |
There was a problem hiding this comment.
This is failing because I merged this PR that changed the component name - just replace this with
import IssueViewsIssueListHeader from 'sentry/views/issueList/issueViewsHeader';
and update the component below
|
PR reverted: fd477cd |
getsentry-bot
added a commit
that referenced
this pull request
Jan 6, 2025
…component (#82784)" This reverts commit 7c678ff. Co-authored-by: malwilley <[email protected]>
malwilley
added a commit
that referenced
this pull request
Jan 6, 2025
#82935) Same as #82784 which got reverted, with the addition of a type failure fix. Adds a copy of overview.tsx (and tests) that is a functional component. I mostly copied it 1 for 1, so the resulting component is not much better than the original. We need a starting place first to start making more improvements. This new component is only rendered if the issue-stream-functional-refactor flag is enabled. We will test this internally before rolling out more widely and deleting the original to reduce risk. The most significant changes were around data fetching and caching, since converting things to useEffects resulted in some bugs and test failures that the original lifecycle methods managed to avoid somehow. For example, we are now using the requestParams object to determine if we should refetch instead of checking against previous props for everything individually. I have also removed issue-stream-performance checks in this version of the component since that complicated things significantly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a copy of overview.tsx (and tests) that is a functional component. I mostly copied it 1 for 1, so the resulting component is not much better than the original. We need a starting place first to start making more improvements.
This new component is only rendered if the
issue-stream-functional-refactorflag is enabled. We will test this internally before rolling out more widely and deleting the original to reduce risk.The most significant changes were around data fetching and caching, since converting things to useEffects resulted in some bugs and test failures that the original lifecycle methods managed to avoid somehow. For example, we are now using the
requestParamsobject to determine if we should refetch instead of checking against previous props for everything individually.I have also removed
issue-stream-performancechecks in this version of the component since that complicated things significantly.