Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(trace) consolidate hooks #81226

Open
wants to merge 1 commit into
base: jb/issues/trace-view
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 25, 2024

When the trace view loads, fetch the spans of the transaction that has the issue associated to it so that we can try and find a more precise child node/span that is associated to the error.

CleanShot 2024-11-24 at 19 27 59@2x

@JonasBa JonasBa requested a review from a team as a code owner November 25, 2024 00:30
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 27 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ews/performance/newTraceDetails/useTraceOnLoad.tsx 62.50% 15 Missing ⚠️
...ce/newTraceDetails/traceModels/issuesTraceTree.tsx 70.58% 10 Missing ⚠️
...rformance/newTraceDetails/issuesTraceWaterfall.tsx 75.00% 1 Missing ⚠️
...nce/newTraceDetails/traceRow/traceCollapsedRow.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           jb/issues/trace-view   #81226      +/-   ##
========================================================
- Coverage                 78.37%   78.37%   -0.01%     
========================================================
  Files                      7216     7216              
  Lines                    317413   317447      +34     
  Branches                  43788    43795       +7     
========================================================
+ Hits                     248766   248788      +22     
- Misses                    62329    62341      +12     
  Partials                   6318     6318              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant