Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit(integrations): replace on-call integration validation error failures with halts #81207

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mifu67
Copy link
Contributor

@mifu67 mifu67 commented Nov 22, 2024

VALIDATE_SERVICE and VERIFY_TEAM only fail due to user error, so we should record halts and not failures if they raise a validation error.

@mifu67 mifu67 requested review from a team as code owners November 22, 2024 20:09
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 22, 2024
@mifu67 mifu67 marked this pull request as draft November 22, 2024 20:10
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/opsgenie/actions/form.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #81207    +/-   ##
========================================
  Coverage   80.34%   80.34%            
========================================
  Files        7215     7217     +2     
  Lines      319407   319522   +115     
  Branches    20775    20775            
========================================
+ Hits       256616   256719   +103     
- Misses      62397    62409    +12     
  Partials      394      394            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant