feat(update-icon): change to ellipsis #81189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Nov 22, 2024
Zylphrex
reviewed
Nov 22, 2024
| @@ -87,7 +87,7 @@ export function AddToDashboardButton({visualizeIndex}: AddToDashboardButtonProps | |||
| <Tooltip title={t('Add to Dashboard')}> | |||
| <Button | |||
| size="sm" | |||
| icon={<IconDashboard />} | |||
| icon={<IconEllipsis />} | |||
There was a problem hiding this comment.
@doralchan is the intention to make the ellipsis open a context menu with an option to add to dashboard? If so, this PR is incorrect as the ellipsis will directly add to dashboard.
There was a problem hiding this comment.
@narsaynorath made the same point but I decided to just wait for him to make the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the near future, we'll be adding the ability to also convert this to an alert
Before:
After:
