Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(trace) remove test skip and stop mocking console error #80158

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/utils/useDispatchingReducer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,12 @@ export function useDispatchingReducer<R extends React.Reducer<any, any>>(
// we are likely going to have to rethrow async and lose stack traces...
actionQueue.current.push(a);

if (updatesRef.current !== null) {
if (updatesRef.current) {
window.cancelAnimationFrame(updatesRef.current);
updatesRef.current = null;
}

window.requestAnimationFrame(() => {
updatesRef.current = window.requestAnimationFrame(() => {
setState(s => {
const next = update(s, actionQueue.current, reducerRef.current, emitter);
stateRef.current = next;
Expand Down
1 change: 1 addition & 0 deletions static/app/views/performance/newTraceDetails/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ export function TraceViewWaterfall(props: TraceViewWaterfallProps) {
) => {
if (searchingRaf.current?.id) {
window.cancelAnimationFrame(searchingRaf.current.id);
searchingRaf.current = null;
}

function done([matches, lookup, activeNodeSearchResult]) {
Expand Down
Loading
Loading