Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): Set Metrics Interface backend to Kafka in self-hosted #55374

Closed
wants to merge 1 commit into from

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Aug 29, 2023

The default behavior is for this backend to be pointing at the Snuba backend, which is incorrect. We want to be using the backend which directly produces the metrics onto the indexer (in the generic metrics platform), which is the Kafka-based backend.

@ayirr7 ayirr7 requested a review from a team as a code owner August 29, 2023 18:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 29, 2023
@ayirr7 ayirr7 requested a review from snigdhas August 29, 2023 18:42
Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot go in until after getsentry/self-hosted#2355 goes in. I plan to merge the self-hosted PR this week

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #55374 (d1a068b) into master (e78c7b4) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #55374   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files        5042     5042           
  Lines      214970   214970           
  Branches    36501    36501           
=======================================
+ Hits       171998   172004    +6     
+ Misses      37686    37683    -3     
+ Partials     5286     5283    -3     

see 3 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Oct 19, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 19, 2023
@getsantry getsantry bot closed this Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants