Add alarm to cut trigger on sentry app webhook timing out#108563
Open
Christinarlong wants to merge 10 commits intomasterfrom
Open
Add alarm to cut trigger on sentry app webhook timing out#108563Christinarlong wants to merge 10 commits intomasterfrom
Christinarlong wants to merge 10 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
Christinarlong
changed the title
With Exception, ignore_unpublished_app_errors swallows timeouts for unpublished (dev/test) apps, which is the correct behavior — the lifecycle halt metric still fires before the re-raise. Tests updated to use published=True so the exception propagates for assertion.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Member
GabeVillalobos
left a comment
GabeVillalobos
left a comment
There was a problem hiding this comment.
Sort of a philosophical question, but could we change the DNS resolution timeout instead, or make it an optional parameter to configure? This seems to sidestep the core issue a little bit.
Comment on lines
+130
to
+136
| with timeout_alarm(timeout_seconds, _handle_webhook_timeout): | ||
| response = safe_urlopen( | ||
| url=url, | ||
| data=app_platform_event.body, | ||
| headers=app_platform_event.headers, | ||
| timeout=options.get("sentry-apps.webhook.timeout.sec"), | ||
| ) |
Member
There was a problem hiding this comment.
What's the purpose of discerning between this and the task-level timeout we already enforce? Is this covering a different code path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in a stacked chain of
crl/add-breaker-to-webhook-sending->crl/add-ff-to-breaker->crl/impl-circuit-breaker->crl/webhook-alarm->masterSummary
sentry.taskworker.workerchildorganizations:sentry-app-webhook-hard-timeoutfeature flag and configurable via thesentry-apps.webhook.hard-timeout.secoption (default 5s)Details