Skip to content

fix(sentry_apps): Defer resource change webhooks until transaction commit #108561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(sentry_apps): Defer resource change webhooks until transaction commit #108561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/sentry/tasks/post_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import sentry_sdk
from django.conf import settings
from django.db import transaction
from django.db.models.signals import post_save
from django.utils import timezone
from google.api_core.exceptions import ServiceUnavailable
Expand Down Expand Up @@ -1166,16 +1167,20 @@ def process_resource_change_bounds(job: PostProcessJob) -> None:
event, is_new = job["event"], job["group_state"]["is_new"]

if event.get_event_type() == "error" and _should_send_error_created_hooks(event.project):
process_resource_change_bound.delay(
action="created",
sender="Error",
instance_id=event.event_id,
project_id=event.project_id,
group_id=event.group_id,
transaction.on_commit(
lambda: process_resource_change_bound.delay(
action="created",
sender="Error",
instance_id=event.event_id,
project_id=event.project_id,
group_id=event.group_id,
)
)
if is_new:
process_resource_change_bound.delay(
action="created", sender="Group", instance_id=event.group_id
transaction.on_commit(
lambda: process_resource_change_bound.delay(
action="created", sender="Group", instance_id=event.group_id
)
)


Expand Down
Loading