Draft
Conversation
Adds validation to schedule_task() to catch schema mismatches early, before tasks are scheduled to the task broker. This prevents task failures when model changes are deployed to task brokers before Sentry workers are updated. Changes: - Validate transformed event payload using Pydantic models before scheduling the Celery task - Use appropriate model (SeerCodeReviewTaskRequestForPrClosed or SeerCodeReviewTaskRequestForPrReview) based on request_type - Log validation failures with detailed context - Record INVALID_PAYLOAD metric when validation fails - Add tests to verify validation happens before task scheduling Fixes: CW-837 Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pre-scheduling validation for
event_payloadwithinschedule_taskto prevent invalid tasks from being queued.This addresses issues where model changes could lead to tasks being scheduled with incompatible payloads when task brokers are updated before Sentry workers, causing failures downstream. Validation now occurs before the Celery task is dispatched, catching schema mismatches early and improving system robustness.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Linear Issue: CW-837