Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API allowing to start/finish transactions and spans with explicit timings #715

Merged
merged 5 commits into from
Dec 22, 2024
Merged

Add API allowing to start/finish transactions and spans with explicit timings #715

merged 5 commits into from
Dec 22, 2024

Conversation

tustanivsky
Copy link
Collaborator

@tustanivsky tustanivsky commented Dec 17, 2024 •
edited
Loading

This PR adds new functions to the plugin's API that allow:

  • Start and finish transactions/spans with additional timestamp parameters to let the user provide explicit timings
  • Create new child spans from the existing span object

Currently, this functionality is limited to Windows and Linux only.

Closes #714

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 995477a

@tustanivsky tustanivsky mentioned this pull request Dec 17, 2024
Closed
@tustanivsky tustanivsky marked this pull request as ready for review December 20, 2024 09:23
@tustanivsky tustanivsky merged commit 5f2e6f4 into main Dec 22, 2024
19 checks passed
@tustanivsky tustanivsky deleted the feat/tx-and-span-timestamp branch December 22, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaDev5 PlasmaDev5 PlasmaDev5 approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distributed tracing: Fixing clock skew
2 participants
@tustanivsky @PlasmaDev5