Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add printing callstack to a log file for assertions/crashes #637

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tustanivsky
Copy link
Collaborator

@tustanivsky tustanivsky commented Sep 23, 2024

This PR adds printing callstack to a log file for assertions and crashes (Windows only).

Closes #630

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a3ee98b

@tustanivsky tustanivsky changed the title Add printing callstack to a log file for assertions Add printing callstack to a log file for assertions/crashes Oct 4, 2024
@tustanivsky tustanivsky marked this pull request as ready for review October 4, 2024 13:37
@bruno-garcia
Copy link
Member

going forward please add @PlasmaDev5 as a reviewer too

@bitsandfoxes
Copy link
Contributor

We're cutting off frames here again. Last time this was kind of urgent to unblock some users but I think it's time to do this properly on sentry itself. We've got enhancement configs here
Ideally, we'd find a way to exclude the offending frames through that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppressed check/assert callstacks and error codes with EnableAutoCrashCapturing
3 participants