Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the collection of
MainThreadData
out of theMonoBehaviour
's Awake call in #1802I'm actually not 100% why that worked in the first place. The Awake happens past the SceneLoad so the contexts should not have been available at that time either.
Why is it broken
RuntimeInitializeLoadType.SubsystemRegistration
sentry-unity/package-dev/Runtime/SentryInitialization.cs
Line 54 in 03af53d
sentry-unity/src/Sentry.Unity/Integrations/UnityScopeIntegration.cs
Lines 46 to 58 in e7a45a9
MainThreadData
has not been collected at this point because this happens duringBeforeSceneLoad
sentry-unity/src/Sentry.Unity/MainThreadData.cs
Lines 75 to 76 in f1fe17a
How to fix it
Instead of relying on the Unity
RuntimeInitialize
we can just collect the contexts right before initializationsentry-unity/src/Sentry.Unity/SentryUnitySDK.cs
Line 31 in e7a45a9
Everything is nice and explicit.
Updated our smoketest so contexts won't go missing anymore.