Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: network image replay breadcrumb #3933

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jul 4, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

The breadcrumb is currently missing for network images. This is what is available in the native breadcrumb:
Screenshot 2024-07-04 at 20 51 05

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- network image replay breadcrumb ([#3933](https://github.com/getsentry/sentry-react-native/pull/3933))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d0671c9

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 504.60 ms 549.24 ms 44.64 ms
Size 17.73 MiB 20.04 MiB 2.30 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
063bfce 469.96 ms 516.38 ms 46.42 ms
41db11d 429.33 ms 451.24 ms 21.91 ms
376301c 445.52 ms 474.70 ms 29.18 ms

App size

Revision Plain With Sentry Diff
063bfce 17.73 MiB 20.04 MiB 2.30 MiB
41db11d 17.73 MiB 20.04 MiB 2.30 MiB
376301c 17.73 MiB 20.04 MiB 2.30 MiB

Copy link
Contributor

github-actions bot commented Jul 4, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.02 ms 1241.67 ms 5.65 ms
Size 2.92 MiB 3.61 MiB 710.22 KiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
063bfce+dirty 1225.38 ms 1218.06 ms -7.31 ms
41db11d+dirty 1208.60 ms 1210.47 ms 1.87 ms
376301c+dirty 1224.74 ms 1227.00 ms 2.26 ms

App size

Revision Plain With Sentry Diff
063bfce+dirty 2.92 MiB 3.61 MiB 710.22 KiB
41db11d+dirty 2.92 MiB 3.61 MiB 705.84 KiB
376301c+dirty 2.92 MiB 3.61 MiB 709.95 KiB

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 365.72 ms 411.16 ms 45.44 ms
Size 7.15 MiB 8.31 MiB 1.17 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
376301c+dirty 353.80 ms 388.54 ms 34.74 ms
41db11d+dirty 374.57 ms 415.25 ms 40.68 ms
063bfce+dirty 338.00 ms 369.88 ms 31.88 ms

App size

Revision Plain With Sentry Diff
376301c+dirty 7.15 MiB 8.31 MiB 1.17 MiB
41db11d+dirty 7.15 MiB 8.31 MiB 1.16 MiB
063bfce+dirty 7.15 MiB 8.31 MiB 1.17 MiB

@krystofwoldrich
Copy link
Member

Is the situation the same on Android?
I know RN uses OkHttp, but I'm not sure if our bytecode manipulation picks it up automatically.

@vaind
Copy link
Collaborator Author

vaind commented Jul 8, 2024

Is the situation the same on Android?

on Android, there are no native request breadcrumbs available for network images - I've checked with the debugger.

Base automatically changed from feat/replay to main July 15, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants