OP_IN, OP_NOT_IN

getsentry · Sep 25, 2024 · fefe11e · fefe11e
1 parent 3da21ea
commit fefe11e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto b/proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto
@@ -16,6 +16,7 @@ message TraceItemAttributeNamesRequest {
  // different typed attributes are queried separately
  // anything other than TYPE_STRING and TYPE_FLOAT will return empty
  AttributeKey.Type type = 5;
+ string value_substring_match = 6;
 }
 
 message TraceItemAttributeNamesResponse {

diff --git a/proto/sentry_protos/snuba/v1/trace_item_attribute.proto b/proto/sentry_protos/snuba/v1/trace_item_attribute.proto
@@ -29,6 +29,14 @@ message VirtualColumnContext {
  map<string, string> value_map = 3;
 }
 
+message StrArray {
+ repeated string values = 1;
+}
+
+message IntArray {
+ repeated int64 values = 1;
+}
+
 message AttributeValue {
  oneof value {
  bool val_bool = 1;
@@ -37,5 +45,7 @@ message AttributeValue {
  int64 val_int = 4;
  // set to true if value is null
  bool val_null = 5;
+ StrArray val_str_array = 6;
+ IntArray val_int_array = 7;
  }
 }
diff --git a/proto/sentry_protos/snuba/v1/trace_item_filter.proto b/proto/sentry_protos/snuba/v1/trace_item_filter.proto
@@ -27,6 +27,8 @@ message ComparisonFilter {
  OP_NOT_EQUALS = 6;
  OP_LIKE = 7; //string only
  OP_NOT_LIKE = 8; //string only
+ OP_IN = 9; // array only
+ OP_NOT_IN = 10; // array only
  }
  AttributeKey key = 1;
  Op op = 2;