Use SENTRY_SPOTLIGHT as default value for Spotlight options
#1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
spotlight-url-from-env
branch
from
6b9a5fd to
235f9b7
Compare
stayallive
force-pushed
the
spotlight-url-from-env
branch
from
235f9b7 to
fd5d15d
Compare
BYK
reviewed
Nov 14, 2024
Member
BYK
left a comment
BYK
left a comment
There was a problem hiding this comment.
LGTM but won't approve until someone from the PHP SDK team takes a look at this.
Member
Member
|
@BYK ? |
Member
|
Lol -- @cleptric was wondering if you have any objections as last time we talked about this you seemed on the fence for making |
Member
|
My opinion on this didn't change, but I won't object these changes. |
BYK
previously requested changes
Nov 19, 2024
Member
BYK
left a comment
BYK
left a comment
There was a problem hiding this comment.
Sending back for deprecation changes.
cleptric
reviewed
Nov 19, 2024
cleptric
approved these changes
Nov 28, 2024
Co-authored-by: Michi Hoffmann <[email protected]>
Co-authored-by: Michi Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads
SENTRY_SPOTLIGHTenvironment variable as source of truth and also allows passing the URL directly to thespotlightoption.Related getsentry/spotlight#545 and getsentry/spotlight#482