This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
fix: Ignore .svelte files by default
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/fix-ignore-svelte-files
branch
from
94c5ff0 to
c49149b
Compare
andreiborza
approved these changes
Jul 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migr8 has some issues with correctly serializing
.sveltefiles. Given that we don't instruct users to use Sentry code in any svelte files (neither for@sentry/sveltenor@sentry/sveltekit) it's unlikely (but still possible) that we miss a lot with this. I think it's fine to just ignore them for the time being.This was reported in #68 but it came up before on twitter as well as at the last Svelte meetup.
Users can opt-out of ignoring
.sveltefiles anyway by specifying the--ignoreFilePatternsargument.Closes #68