Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Revert "meta(changelog): Update changelog for 0.2.3" #63

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

andreiborza
Copy link
Member

Reverts #60 because the release didn't go through.. 😅. Trying again.

@andreiborza andreiborza requested review from Lms24 and mydea July 5, 2024 09:31
@andreiborza
Copy link
Member Author

Tbh, not sure what a good workflow should be for these cases...

@Lms24
Copy link
Member

Lms24 commented Jul 5, 2024

The changelog policy for migr8 is currently set to auto in the craft config, meaning the new changelog should have a ## Unreleased section with the new items which will be set to the version by craft during release preparation.

@Lms24
Copy link
Member

Lms24 commented Jul 5, 2024

I vote we either set the policy to simple like in sentry-javascript or add the Danger workflow to get a PR comment to remind us of adding a changelog item. I'd slightly prefer the second alternative because the repo is small enough that adding a changelog entry to the respective PR as opposed to crafting a changelog before the release makes sense IMO. But no strong feelings - feel free to go with whatever you prefer

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge this or change ## 0.2.3 to ## Unreleased (see my comment)

@andreiborza andreiborza force-pushed the revert-60-prepare-release/0.2.3 branch from df1bfbc to 3406b80 Compare July 5, 2024 12:03
@andreiborza andreiborza merged commit 82205f6 into main Jul 5, 2024
3 checks passed
@andreiborza andreiborza deleted the revert-60-prepare-release/0.2.3 branch July 5, 2024 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants