This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
feat: Add transform to extract node config into separate file #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
May 13, 2024
| * Whether the transformer requires user input to run | ||
| * If true, the transformer won't show a spinner to avoid cluttering the spinner with user prompts. | ||
| */ | ||
| requiresUserInput?: boolean; |
There was a problem hiding this comment.
This was necessary b/c otherwise the spinner would show while the user input prompt was showing and the process is waiting for user input. This would severely decrease UX because users might see the spinner as a sign that something is still loading or already going on, not making it clear that they actually need to provide input.
Lms24
reviewed
May 13, 2024
Comment on lines
+18
to
+19
| '@sentry/deno', | ||
| '@sentry/bun', |
There was a problem hiding this comment.
sneaking this into the PR, we should add Deno and Bun to this list
|
UPDATE: This is no longer the end result; just leaving this here for context
|
|
After revisiting the CLI arg decision, we're now back to no prompts:
|
mydea
commented
May 13, 2024
| After you've done that, remove import of ${chalk.cyan('instrument.js')} from your file(s). | ||
|
|
||
| This only applies if you are actually using ESM natively with Node. | ||
| If you use ${chalk.gray('import')} syntax but transpile to CommonJS (e.g. TypeScript), you're all set up already! |
Lms24
approved these changes
May 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transform will try to detect
Sentry.init()when using@sentry/node, and extract it into a separate fileinstrument.jsthat is required/imported at the very top of the file.