Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

feat: Add migration comment transform #27

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: Add migration comment transform #27

merged 2 commits into from
Apr 23, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 23, 2024

This transform will find the following things and inject a comment about needing to change them:

  • startTransaction()
  • startChild()
  • new Hub()
  • makeMain()

There may be more things to add there, but it's a start!

Closes #24

@mydea mydea requested review from Lms24, AbhiPrasad and s1gr1d April 23, 2024 12:24
@mydea mydea self-assigned this Apr 23, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Can we add a test for top-level and function body usage of these APIs? Judinging by this test it should work but it probably makes sense to have this rather likely scenario covered.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, done!

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea mydea merged commit 5fe621a into main Apr 23, 2024
2 checks passed
@mydea mydea deleted the fn/add-comments branch April 23, 2024 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comments for things that users need to manually migrate
2 participants