test(android): add proguard tombstone test cases#5117
Open
supervacuus wants to merge 2 commits intofix/android/id_java_kotlin_frames_tombstonefrom
Open
test(android): add proguard tombstone test cases#5117supervacuus wants to merge 2 commits intofix/android/id_java_kotlin_frames_tombstonefrom
supervacuus wants to merge 2 commits intofix/android/id_java_kotlin_frames_tombstonefrom
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
...-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt
Show resolved
Hide resolved
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9f7b6b | 296.53 ms | 355.34 ms | 58.81 ms |
| 238420b | 318.77 ms | 364.60 ms | 45.83 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9f7b6b | 1.58 MiB | 2.29 MiB | 720.04 KiB |
| 238420b | 1.58 MiB | 2.29 MiB | 720.12 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR sits on top of #5116, but I added it separately because it addresses a different topic: tombstone frames that are ProGuard-obfuscated.
The former should be merged into
master. We don't have to merge the latter to master, but I think it will be could be useful for @markushi in https://linear.app/getsentry/issue/ANDROID-265/improve-ux-for-mixed-stacktraces (getsentry/sentry#107318), because it allows cross-checking UI changes for proguard.The PR also allows us to verify that the ProGuard debug-meta is correctly appended to tombstone and ANR events when a corresponding properties file exists in the APK. If a mapping file has been uploaded with
sentry-clior the SAGP, the backend correctly triggers ProGuard deobfuscation, but it only deobfuscates themodule, not thefunction:Not sure if that is expected behavior (event).
#skip-changelog
(since this is currently only an internal test addition)
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps