Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] GA Session replay #4017

Merged
merged 33 commits into from
Jan 2, 2025
Merged

[SR] GA Session replay #4017

merged 33 commits into from
Jan 2, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 2, 2025

📜 Description

  • Move SessionReplay suboptions from experimental to the core SentryOptions. I kept ExperimentalOptions around as-is for future feature launches

💡 Motivation and Context

Part of getsentry/sentry#74441
Closes #2476

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [] I updated the docs if needed.
  • [] I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 522.88 ms 620.53 ms 97.65 ms
Size 1.70 MiB 2.36 MiB 672.02 KiB

Previous results on branch: rz/feat/session-replay-ga

Startup times

Revision Plain With Sentry Diff
c1de79e 417.94 ms 437.78 ms 19.84 ms
b8d55f8 473.28 ms 535.78 ms 62.50 ms
e26457f 371.33 ms 411.06 ms 39.73 ms

App size

Revision Plain With Sentry Diff
c1de79e 1.70 MiB 2.36 MiB 672.02 KiB
b8d55f8 1.70 MiB 2.36 MiB 672.02 KiB
e26457f 1.70 MiB 2.36 MiB 672.02 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

romtsn and others added 2 commits January 2, 2025 18:08
Co-authored-by: Stefano <[email protected]>
Co-authored-by: Stefano <[email protected]>
Base automatically changed from rz/fix/delete-corrupted-frames to main January 2, 2025 18:43
@romtsn romtsn enabled auto-merge (squash) January 2, 2025 18:46
@romtsn romtsn merged commit 4267ac9 into main Jan 2, 2025
31 of 32 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-ga branch January 2, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Replay for native Android applications
3 participants