Conversation
14f7cf6 to
14777b3
Compare
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
jpnurmi
left a comment
There was a problem hiding this comment.
Notice that sentry-cocoa v9 bumped the minimum iOS version from 13.0 to 15.0. What's the current minimum iOS version for sentry-godot?
|
@jpnurmi Godot supports 14.0+ for Metal renderer, and also can accept even lower versions if using Vulkan renderer. For our extension, we are not specifying directly - so it has to default to 12.0. Looks like I need to add the minimum version to the build workflow, and check if Godot editor properly processes it (like a warning if exporting for <15.0). We can add our own warnings to the editor export dialog via export plugins. It's unfortunate that our minimum support is lower than the engine's. This means that users will need to set it up higher. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
a63ded2 to
ddaa882
Compare
Summary
Bumps sentry-cocoa from v8.57.3 to v9.4.1.
Breaking changes
Changes
SentryStructuredLogAttribute→SentryLogAttribute,SentryStructuredLogLevel→SentryLogLevelenableLogsfromoptions.experimentaltooptions(promoted from experimental in 9.x)SentryId.himport (no longer included via umbrella header)9.0.0-alpha.0) using regexios_min_version=15.0in CI build matrix for iOS targetsmacos_deployment_targetfrom 11.0 to 10.14 to match Cocoa SDK minimumios_min_versioninsentry-cocoa.SConscriptfrom12.0to15.0References
Supersedes #456