[v9] Remove max response body size #2709
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2709 +/- ##
==========================================
- Coverage 88.32% 88.25% -0.07%
==========================================
Files 262 262
Lines 8913 8890 -23
==========================================
- Hits 7872 7846 -26
- Misses 1041 1044 +3 ☔ View full report in Codecov by Sentry. |
denrase
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
|
@denrase nice! could you also prepare a PR deprecating these for the main branch pls |
| } else { | ||
| return null; | ||
| } | ||
| if (contentLength > 157286) { |
There was a problem hiding this comment.
this is in bytes right? so the max is 0.15mb?
because in the changelog you mention 15mb which is a lot
There was a problem hiding this comment.
Ah, changelog was a mistake, will fix!
| @@ -11,6 +11,9 @@ | |||
| - Remove `options.autoAppStart` and `setAppStartEnd` ([#2680](https://github.com/getsentry/sentry-dart/pull/2680)) | |||
| - Add hint for transactions ([#2675](https://github.com/getsentry/sentry-dart/pull/2675)) | |||
| - `BeforeSendTransactionCallback` now has a `Hint` parameter | |||
| - Remove max response body size ([#2709](https://github.com/getsentry/sentry-dart/pull/2709)) | |||
| - Responses are now only attached if size is below ~15mb | |||
There was a problem hiding this comment.
| - Responses are now only attached if size is below ~15mb | |
| - Responses are now only attached if size is below ~0.15mb |
| @@ -11,6 +11,9 @@ | |||
| - Remove `options.autoAppStart` and `setAppStartEnd` ([#2680](https://github.com/getsentry/sentry-dart/pull/2680)) | |||
| - Add hint for transactions ([#2675](https://github.com/getsentry/sentry-dart/pull/2675)) | |||
| - `BeforeSendTransactionCallback` now has a `Hint` parameter | |||
| - Remove max response body size ([#2709](https://github.com/getsentry/sentry-dart/pull/2709)) | |||
| - Responses are now only attached if size is below ~15mb | |||
There was a problem hiding this comment.
and also pls mention that this is currently only applicable for the dio integration, not our http integration
There was a problem hiding this comment.
our http integration doesn't support capturing the response data generally, we could add that feature later at some point
|
@buenaflor The contexts still have response. Should we deprecate it? |
|
@denrase I believe so, could you check if other sdks have this in the contexts |
|
https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/#response-context we can leave the response, we just have to be clear that we will not add the response body/data automatically, the user has to do that themselves via the hints |
📜 Description
💡 Motivation and Context
Closes #2637
Closes #2638
💚 How did you test it?
Tests
📝 Checklist
sendDefaultPiiis enabled