Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ttfd): measurements should only be added for successful ttfd #2348

Merged
merged 4 commits into from
Oct 14, 2024

update

ed28c79
Select commit
Loading
Failed to load commit list.
Merged

fix(ttfd): measurements should only be added for successful ttfd #2348

update
ed28c79
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 14, 2024 in 0s

85.13% (+0.32%) compared to f3a18f2

View this Pull Request on Codecov

85.13% (+0.32%) compared to f3a18f2

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (f3a18f2) to head (ed28c79).

Files with missing lines Patch % Lines
...b/src/navigation/time_to_full_display_tracker.dart 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
+ Coverage   84.81%   85.13%   +0.32%     
==========================================
  Files         253       79     -174     
  Lines        9054     2785    -6269     
==========================================
- Hits         7679     2371    -5308     
+ Misses       1375      414     -961     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.