Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocked_main_thread to sync file spans #1801

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Merge branch 'main' into enha/file-isolate-name

a5d3d15
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Add blocked_main_thread to sync file spans #1801

Merge branch 'main' into enha/file-isolate-name
a5d3d15
Select commit
Loading
Failed to load commit list.
GitHub Actions / Analysis of sentry_file succeeded Jan 30, 2024 in 1m 25s

Package analysis results for sentry_file

Score

90/140 points
(64.28571428571429%)

Details

Follow Dart file conventions (30/30)

✔ 10/10 points: Provide a valid pubspec.yaml

✔ 5/5 points: Provide a valid README.md

✔ 5/5 points: Provide a valid CHANGELOG.md

✔ 10/10 points: Use an OSI-approved license

Detected license: MIT.

Provide documentation (20/20)

✔ 10/10 points: 20% or more of the public API has dartdoc comments

51 out of 54 API elements (94.4 %) have documentation comments.

Some symbols that are missing documentation: sentry_file, sentry_file.Callback, sentry_file.SentryFileExtension.

✔ 10/10 points: Package has an example

Platform support (20/20)

✔ 20/20 points: Supports 5 of 6 possible platforms (iOS, Android, Web, Windows, MacOS, Linux)

  • ✓ Android
  • ✓ iOS
  • ✓ Windows
  • ✓ Linux
  • ✓ MacOS

These platforms are not supported:

Package not compatible with platform Web

Because:

  • package:sentry_file/sentry_file.dart that imports:
  • package:sentry_file/src/sentry_io_overrides.dart that imports:
  • package:sentry/sentry.dart that imports:
  • package:sentry/src/type_check_hint.dart that imports:
  • package:sentry/src/http_client/failed_request_client.dart that imports:
  • package:sentry/src/http_client/sentry_http_client.dart that imports:
  • package:sentry/src/http_client/breadcrumb_client.dart that imports:
  • package:sentry/src/hub_adapter.dart that imports:
  • package:sentry/src/sentry_client.dart that imports:
  • package:sentry/src/transport/spotlight_http_transport.dart that imports:
  • package:sentry/src/utils/transport_utils.dart that imports:
  • package:sentry/sentry_io.dart that imports:
  • package:sentry/src/sentry_isolate.dart that imports:
  • dart:isolate

Pass static analysis (0/50)

❌ 0/50 points: code has no errors, warnings, lints, or formatting issues

ERROR: The method 'isMainIsolate' isn't defined for the type 'SentryOptions'.

lib/src/sentry_file.dart:493:40

    ╷
493 │     final isMainIsolate = _hub.options.isMainIsolate();
    │                                        ^^^^^^^^^^^^^
    ╵

To reproduce make sure you are using the lints_core and run dart analyze lib/src/sentry_file.dart

Support up-to-date dependencies (20/20)

✔ 10/10 points: All of the package dependencies are supported in the latest version

Package Constraint Compatible Latest
meta ^1.3.0 1.11.0 1.11.0
sentry 7.15.0 7.15.0 7.15.0
Transitive dependencies
Package Constraint Compatible Latest
async - 2.11.0 2.11.0
collection - 1.18.0 1.18.0
crypto - 3.0.3 3.0.3
fixnum - 1.1.0 1.1.0
http - 1.2.0 1.2.0
http_parser - 4.0.2 4.0.2
path - 1.9.0 1.9.0
source_span - 1.10.0 1.10.0
sprintf - 7.0.0 7.0.0
stack_trace - 1.11.1 1.11.1
string_scanner - 1.2.0 1.2.0
term_glyph - 1.2.1 1.2.1
typed_data - 1.3.2 1.3.2
uuid - 4.3.3 4.3.3
web - 0.4.2 0.4.2

To reproduce run dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides.

✔ 10/10 points: Package supports latest stable Dart and Flutter SDKs

Versions