ref: rename Batcher to TelemetryBuffer #7220
Open
+180
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step for #7210. More class renames coming in follow-up PRs.
Renames the generic buffering infrastructure from Batcher to TelemetryBuffer to better reflect its purpose and avoid confusion with the SentryMetricsBatcher (now SentryMetricsTelemetryBuffer). Changes: - Renamed Tools/Batcher folder to Tools/TelemetryBuffer - Renamed all Batcher* classes to TelemetryBuffer*: - BatcherProtocol -> TelemetryBufferProtocol - BatcherConfig -> TelemetryBufferConfig - BatcherItem -> TelemetryBufferItem - BatcherScope -> TelemetryBufferScope - BatcherMetadata -> TelemetryBufferMetadata - InternalBuffer -> InternalTelemetryBuffer - InMemoryInternalBuffer -> InMemoryInternalTelemetryBuffer - Renamed SentryMetricsBuffer to SentryMetricsTelemetryBuffer - Updated all references and comments - Updated all test files accordingly The SentryLogBatcher class name will be renamed in an upcoming PR.
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
philipphofmann
added
the
ready-to-merge
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7220 +/- ##
=============================================
- Coverage 85.452% 85.099% -0.353%
=============================================
Files 468 468
Lines 28348 28348
Branches 12527 12534 +7
=============================================
- Hits 24224 24124 -100
- Misses 3865 4182 +317
+ Partials 259 42 -217
... and 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the generic buffering infrastructure from Batcher to TelemetryBuffer.
This is the second step for #7210.
Changes
Tools/Batcher→Tools/TelemetryBufferfolderBatcherProtocol→TelemetryBufferProtocolBatcherConfig→TelemetryBufferConfigBatcherItem→TelemetryBufferItemBatcherScope→TelemetryBufferScopeBatcherMetadata→TelemetryBufferMetadataInternalBuffer→InternalTelemetryBufferInMemoryInternalBuffer→InMemoryInternalTelemetryBufferSentryMetricsBuffer→SentryMetricsTelemetryBufferSentryMetricsBufferProtocol→SentryMetricsTelemetryBufferProtocolSentryMetricsBufferOptionsProtocol→SentryMetricsTelemetryBufferOptionsProtocolSentryLogBatcherclass name (will be renamed in an upcoming PR)Notes
#skip-changelog