chore: Convert SentryNSDataSwizzling and SentryNSFileManagerSwizzling to Swift #7209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for swizzling functionality
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Metrics
Other
Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7209 +/- ##
=============================================
+ Coverage 85.037% 85.096% +0.058%
=============================================
Files 468 470 +2
Lines 28305 28302 -3
Branches 12535 12533 -2
=============================================
+ Hits 24070 24084 +14
+ Misses 4194 3958 -236
- Partials 41 260 +219
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21cd5ba | 1218.68 ms | 1255.54 ms | 36.86 ms |
| adeec82 | 1220.43 ms | 1254.94 ms | 34.51 ms |
| 41b4993 | 1215.15 ms | 1248.14 ms | 32.99 ms |
| 2f4ddaa | 1227.26 ms | 1260.04 ms | 32.78 ms |
| d29a425 | 1209.96 ms | 1239.00 ms | 29.04 ms |
| 778dadf | 1207.69 ms | 1246.09 ms | 38.40 ms |
| b87b34f | 1203.00 ms | 1237.17 ms | 34.17 ms |
| e1e5f3b | 1220.60 ms | 1241.63 ms | 21.04 ms |
| 93ef486 | 1220.22 ms | 1244.96 ms | 24.74 ms |
| 3bf0d3f | 1202.12 ms | 1237.23 ms | 35.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21cd5ba | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| adeec82 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 41b4993 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 2f4ddaa | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| d29a425 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 778dadf | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| b87b34f | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| e1e5f3b | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 93ef486 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 3bf0d3f | 24.14 KiB | 1.04 MiB | 1.02 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Converted SentryNSDataSwizzling and SentryNSFileManagerSwizzling to Swift, keeping some helper in ObjC for the swizzling.
💡 Motivation and Context
Converts some classes required to unlock other conversions to Swift.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.